From c4061c3b95a63892c58096f13b320acea5df2af8 Mon Sep 17 00:00:00 2001 From: psucien Date: Sat, 29 Jun 2024 17:39:31 +0200 Subject: [PATCH] amdgpu: fix for wrong constant ram offset in `WriteConstRam` decoding --- src/video_core/amdgpu/pm4_cmds.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/video_core/amdgpu/pm4_cmds.h b/src/video_core/amdgpu/pm4_cmds.h index 88697d31..5b49157a 100644 --- a/src/video_core/amdgpu/pm4_cmds.h +++ b/src/video_core/amdgpu/pm4_cmds.h @@ -518,13 +518,14 @@ struct PM4CmdEventWriteEos { struct PM4WriteConstRam { PM4Type3Header header; union { - BitField<0, 16, u32> offset; // in DWs + BitField<0, 16, u32> offset; ///< Starting DW granularity offset into the constant RAM. + ///< Thus, bits[1:0] are zero. u32 dw1; }; u32 data[0]; [[nodiscard]] u32 Offset() const { - return offset.Value() << 2u; + return offset.Value(); } [[nodiscard]] u32 Size() const {