catto
/
shadPS4
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

core,shader_recompiler: added const ref filesystem::path and removed if type size less 16 (#446)

This commit is contained in:
Herman Semenov 2024-08-16 08:36:05 +00:00 committed by GitHub
parent 3197ad336e
commit c1fb5d5bca
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
8 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/file_format/pkg.cpp
View File

@ -350,7 +350,7 @@ bool PKG::Extract(const std::filesystem::path& filepath, const std::filesystem::
return true; return true;
} }
void PKG::ExtractFiles(const int& index) { void PKG::ExtractFiles(const int index) {
int inode_number = fsTable[index].inode; int inode_number = fsTable[index].inode;
int inode_type = fsTable[index].type; int inode_type = fsTable[index].type;
std::string inode_name = fsTable[index].name; std::string inode_name = fsTable[index].name;

2
src/core/file_format/pkg.h
View File

@ -104,7 +104,7 @@ public:
~PKG(); ~PKG();
bool Open(const std::filesystem::path& filepath); bool Open(const std::filesystem::path& filepath);
void ExtractFiles(const int& index); void ExtractFiles(const int index);
bool Extract(const std::filesystem::path& filepath, const std::filesystem::path& extract, bool Extract(const std::filesystem::path& filepath, const std::filesystem::path& extract,
std::string& failreason); std::string& failreason);

4
src/core/file_format/trp.cpp
View File

@ -6,7 +6,7 @@
TRP::TRP() = default; TRP::TRP() = default;
TRP::~TRP() = default; TRP::~TRP() = default;
void TRP::GetNPcommID(std::filesystem::path trophyPath, int index) { void TRP::GetNPcommID(const std::filesystem::path& trophyPath, int index) {
std::filesystem::path trpPath = trophyPath / "sce_sys/npbind.dat"; std::filesystem::path trpPath = trophyPath / "sce_sys/npbind.dat";
Common::FS::IOFile npbindFile(trpPath, Common::FS::FileAccessMode::Read); Common::FS::IOFile npbindFile(trpPath, Common::FS::FileAccessMode::Read);
if (!npbindFile.IsOpen()) { if (!npbindFile.IsOpen()) {
@ -27,7 +27,7 @@ static void removePadding(std::vector<u8>& vec) {
} }
} }
bool TRP::Extract(std::filesystem::path trophyPath) { bool TRP::Extract(const std::filesystem::path& trophyPath) {
std::string title = trophyPath.filename().string(); std::string title = trophyPath.filename().string();
std::filesystem::path gameSysDir = trophyPath / "sce_sys/trophy/"; std::filesystem::path gameSysDir = trophyPath / "sce_sys/trophy/";
if (!std::filesystem::exists(gameSysDir)) { if (!std::filesystem::exists(gameSysDir)) {

4
src/core/file_format/trp.h
View File

@ -33,8 +33,8 @@ class TRP {
public: public:
TRP(); TRP();
~TRP(); ~TRP();
bool Extract(std::filesystem::path trophyPath); bool Extract(const std::filesystem::path& trophyPath);
void GetNPcommID(std::filesystem::path trophyPath, int index); void GetNPcommID(const std::filesystem::path& trophyPath, int index);
private: private:
Crypto crypto; Crypto crypto;

2
src/shader_recompiler/ir/attribute.h
View File

@ -105,7 +105,7 @@ struct fmt::formatter<Shader::IR::Attribute> {
constexpr auto parse(format_parse_context& ctx) { constexpr auto parse(format_parse_context& ctx) {
return ctx.begin(); return ctx.begin();
} }
auto format(const Shader::IR::Attribute& attribute, format_context& ctx) const { auto format(const Shader::IR::Attribute attribute, format_context& ctx) const {
return fmt::format_to(ctx.out(), "{}", Shader::IR::NameOf(attribute)); return fmt::format_to(ctx.out(), "{}", Shader::IR::NameOf(attribute));
} }
}; };

2
src/shader_recompiler/ir/condition.h
View File

@ -44,7 +44,7 @@ constexpr std::string_view NameOf(Condition condition) {
template <> template <>
struct fmt::formatter<Shader::IR::Condition> : formatter<std::string_view> { struct fmt::formatter<Shader::IR::Condition> : formatter<std::string_view> {
auto format(const Shader::IR::Condition& cond, format_context& ctx) const { auto format(const Shader::IR::Condition cond, format_context& ctx) const {
return formatter<string_view>::format(NameOf(cond), ctx); return formatter<string_view>::format(NameOf(cond), ctx);
} }
}; };

8
src/shader_recompiler/ir/passes/ssa_rewrite_pass.cpp
View File

@ -129,19 +129,19 @@ IR::Opcode UndefOpcode(IR::VectorReg) noexcept {
return IR::Opcode::UndefU32; return IR::Opcode::UndefU32;
} }
IR::Opcode UndefOpcode(const VccLoTag&) noexcept { IR::Opcode UndefOpcode(const VccLoTag) noexcept {
return IR::Opcode::UndefU32; return IR::Opcode::UndefU32;
} }
IR::Opcode UndefOpcode(const SccLoTag&) noexcept { IR::Opcode UndefOpcode(const SccLoTag) noexcept {
return IR::Opcode::UndefU32; return IR::Opcode::UndefU32;
} }
IR::Opcode UndefOpcode(const VccHiTag&) noexcept { IR::Opcode UndefOpcode(const VccHiTag) noexcept {
return IR::Opcode::UndefU32; return IR::Opcode::UndefU32;
} }
IR::Opcode UndefOpcode(const FlagTag&) noexcept { IR::Opcode UndefOpcode(const FlagTag) noexcept {
return IR::Opcode::UndefU1; return IR::Opcode::UndefU1;
} }

2
src/shader_recompiler/runtime_info.h
View File

@ -226,7 +226,7 @@ struct fmt::formatter<Shader::Stage> {
constexpr auto parse(format_parse_context& ctx) { constexpr auto parse(format_parse_context& ctx) {
return ctx.begin(); return ctx.begin();
} }
auto format(const Shader::Stage& stage, format_context& ctx) const { auto format(const Shader::Stage stage, format_context& ctx) const {
constexpr static std::array names = {"fs", "vs", "gs", "es", "hs", "ls", "cs"}; constexpr static std::array names = {"fs", "vs", "gs", "es", "hs", "ls", "cs"};
return fmt::format_to(ctx.out(), "{}", names[static_cast<size_t>(stage)]); return fmt::format_to(ctx.out(), "{}", names[static_cast<size_t>(stage)]);
} }